(v3.0.x) Remove asciidoctorj deprecated methods usage #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fig is present * Remove use of deprecated AsciidoctorJ methods * Refactor SiteConversionConfigurationParser to simplify
abelsromero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Started to remove the use of AsciidoctorJ methods but I also fixes a bug in the site integration found during the refactor.
In short, maven project properties were not added as Asciidoctor attributes when no site configuration was added.
Are there any alternative ways to implement this?
No.
For context, I bumped into AsciidoctorJ v3.0.0-alpha.1, fixed issues in API (not extensions), and then went back to v2.5.10 to ensure all was working fine.
Are there any implications of this pull request? Anything a user must know?
No
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc
Only the fix will be documented, the other changes are internal.