Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set minimal maven version to 3.9.x & bump dependencies #629

Merged
merged 4 commits into from Mar 20, 2023
Merged

Set minimal maven version to 3.9.x & bump dependencies #629

merged 4 commits into from Mar 20, 2023

Conversation

abelsromero
Copy link
Member

Bump dependencies:

  • maven-core v3.9.1
  • commons-io v2.11.0
  • plexus-utils v3.5.1

Plugins

  • maven-plugin-plugin v3.8.1
  • maven-plugin-annotations v3.8.1
  • plexus-component-metadata v2.1.1
  • maven-enforcer-plugin v3.2.1
  • maven-compiler-plugin v3.11.0
  • maven-release-plugin v3.0.0-M7 (validated it works fine with 2.2.3 release)
  • maven-javadoc-plugin v3.5.0
  • maven-surefire-plugin v3.7.0
  • maven-invoker-plugin v3.4.0 (there's a known issue preventing v3.5.0 use)

@abelsromero
Set minimal maven version to 3.9.x
b283a74 
* Bump dependencies:
  maven-core v3.9.1
  commons-io v2.11.0
  plexus-utils v3.5.1
* Plugins
  maven-plugin-plugin v3.8.1
  maven-plugin-annotations v3.8.1
  plexus-component-metadata v2.1.1
  maven-enforcer-plugin v3.2.1
  maven-compiler-plugin v3.11.0
  maven-release-plugin v3.0.0-M7 (validated it works fine with 2.2.3 release)
  maven-javadoc-plugin v3.5.0
  maven-surefire-plugin v3.7.0
  maven-invoker-plugin v3.4.0 (there's a known issue preventing v3.5.0 use)
@abelsromero
Bump Maven wrapper to 3.9.1
a1a1364
@abelsromero abelsromero marked this pull request as draft March 19, 2023 23:20
@abelsromero
Copy link
Member Author

Back to "draft" status while looking at the issues with integration tests.

@abelsromero
Copy link
Member Author

Found that org.codehaus.plexus:plexus-utils is not being added to ITs classpath even when it's part of the provided libraries of Maven. Setting as compile scope works but it should not be necessary.

@abelsromero
Copy link
Member Author

The issue seems a side-effect

@abelsromero
Copy link
Member Author

abelsromero commented Mar 20, 2023 •
edited

The issue seems a side effect of this change
image

See https://issues.apache.org/jira/browse/MNG-6965.

For now we are going to set plexus-utils as compile dependency and keep track of the fix (or lack of it) in upstream Maven.

@abelsromero abelsromero marked this pull request as ready for review March 20, 2023 09:31
@abelsromero abelsromero merged commit 052a899 into asciidoctor:main Mar 20, 2023
9 checks passed
@abelsromero
Copy link
Member Author

It's been confirmed in https://issues.apache.org/jira/browse/MNG-6965 that this is not an issue, and plexus-utils must be set as compile 👍

@abelsromero abelsromero deleted the bump-dependencies branch December 28, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@abelsromero