Replace reflection by direct JavaExtensionRegistry calls #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Stops any possible usage of AsciidoctorJ v1.6.x (long not supported) * Fixes issue where registering a non-Processor class was ignored without error * Small improvements to JavaDocs closes asciidoctor#568
abelsromero
force-pushed
the
issue-568-remove-reflection-in-AsciidoctorJExtensionRegistry
branch
from
0867747
to
b8e7ed0
Compare
abelsromero
deleted the
issue-568-remove-reflection-in-AsciidoctorJExtensionRegistry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #568
Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Mostly simplify code, functionality has been kept (other than fixing an un-reported error case).
Are there any alternative ways to implement this?
We are still instantiating the Class internally to check it and report any error with it instead of passing it to AsciidoctorJ as string.
We could do it, but then AsciidoctorJ would instantiate it again, decreasing performace.
Are there any implications of this pull request? Anything a user must know?
People still using v1.6.x will have to migrate, but the change is trivial, has no drawbacks and that version has not been supported by the latest plugin already.
Is it related to an existing issue?
Finally, please add a corresponding entry to CHANGELOG.adoc