Split plugin and site modules #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now the doxia module is calle |
* Remove use of deprecated constructor * Add 'asciidoc' as valid file extension
abelsromero
force-pushed
the
issue-574-split-plugin-and-site-modules
branch
from
bb54a92
to
3d3af7b
Compare
|
IMPORTANT: For history reasons I am not changing the project repo yet. I have seen IntelliJ not liking that the parent module is "asciidoctor-maven-tools" and the folder is "asciidoctor-maven-plugin", and furthermore there's sub-module called "asciidoctor-maven-plugin" ... but can be fixed renaming the folder. |
|
Completed successfull deployment (just staging) on Maven Central with new structure, this will be the layout, the new artifacts all appear under
|
abelsromero
added a commit
that referenced
this pull request
Aug 25, 2022
* Create parent module: asciidoctor-maven-tools * Create new dedicated modules: asciidoctor-maven-plugin, asciidoctor-doxia-module, asciidoctor-maven-commons * Remove unused gmaven-plugin eclipse condiguration * Remove use of commons-lang3 for StringUtils.isBlank * Remove use of deprecated constructor in AsciidoctorDoxiaParserModule * Add 'asciidoc' as valid file extension in AsciidoctorDoxiaParserModule * Update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!
What kind of change does this PR introduce? (check at least one)
What is the goal of this pull request?
Splig the Maven Plugin and Doxia components in different modules following Maven practices.
Current Jar works as both because we are generating the appropiate metadata for both use cases, but it requires users to download dependencies they don't need.
Are there any alternative ways to implement this?
n/a
Are there any implications of this pull request? Anything a user must know?
Published artifacts change, from single jar
org.asciidoctor:asciidoctor-maven-pluginwe will have 3:org.asciidoctor:asciidoctor-maven-pluginorg.asciidoctor:asciidoctor-doxia-moduleorg.asciidoctor:asciidoctor-maven-commons(shared dependency by both).Is it related to an existing issue?
Closes #574
Finally, please add a corresponding entry to CHANGELOG.adoc