Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix absolute to relative path #592

Merged
merged 4 commits into from
Aug 18, 2022
Merged

Fix absolute to relative path #592

merged 4 commits into from
Aug 18, 2022

Conversation

MarkusTiede
Copy link
Contributor

Thank you for opening a pull request and contributing to asciidoctor-maven-plugin!

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Documentation
  • Refactor
  • Build improvement
  • Other (please describe)

What is the goal of this pull request?

Are there any alternative ways to implement this?

Are there any implications of this pull request? Anything a user must know?

Is it related to an existing issue?

  • Yes
  • No

Finally, please add a corresponding entry to CHANGELOG.adoc

README.adoc Outdated
@@ -86,7 +86,7 @@ endif::[]

These are the minimal steps to convert your AsciiDoc documents to HTML with the asciidoctor-maven-plugin.

. Place your Asciidoc sources in [.path]_/src/docs/asciidoc_.
. Place your Asciidoc sources in [.path]_src/docs/asciidoc_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! While you are on this line, could you also change Asciidoc to AsciiDoc?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - 96af436

@abelsromero
Copy link
Member

I feel sorry for asking, but wouldn't be nice to take credit since you spoted it. The same section is replicated in usage.adoc, is it too much to ask to fix it too?

@MarkusTiede
Copy link
Contributor Author

Sure - @abelsromero : thanks for noticing!

@abelsromero abelsromero merged commit 593cdba into asciidoctor:main Aug 18, 2022
@abelsromero
Copy link
Member

Thanks!

abelsromero pushed a commit that referenced this pull request Aug 18, 2022
* Fix absolute to relative path in README and usage.adoc
* Fix Asciidoc > AsciiDoc
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Aug 18, 2022
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Aug 18, 2022
abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Aug 18, 2022
@MarkusTiede MarkusTiede deleted the patch-1 branch August 23, 2022 08:10
abelsromero pushed a commit that referenced this pull request Mar 15, 2023
* Fix absolute to relative path in README and usage.adoc
* Fix Asciidoc > AsciiDoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants