Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a consistent policy on where the code should call process.exit #86

Open
ggrossetie opened this issue Feb 1, 2020 · 0 comments · May be fixed by #88
Open

Use a consistent policy on where the code should call process.exit #86

ggrossetie opened this issue Feb 1, 2020 · 0 comments · May be fixed by #88

Comments

@ggrossetie
Copy link
Member

I think we should add a "naming" rule:

  • Functions named "convert..." should not exit the process
  • Functions named "invoke..." should exit the process
ggrossetie added a commit to ggrossetie/asciidoctor-cli.js that referenced this issue Feb 1, 2020
@ggrossetie
resolves asciidoctor#86 exit process consistency
6115734
@ggrossetie ggrossetie linked a pull request Feb 1, 2020 that will close this issue
Open
ggrossetie added a commit to ggrossetie/asciidoctor-cli.js that referenced this issue Feb 1, 2020
@ggrossetie
resolves asciidoctor#86 exit process consistency
babb542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolves #86 exit process consistency ggrossetie/asciidoctor-cli.js
1 participant
@ggrossetie