Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions bug #148

Closed
arvkevi opened this issue Apr 28, 2023 · 1 comment
Closed

GH Actions bug #148

arvkevi opened this issue Apr 28, 2023 · 1 comment

Comments

@arvkevi
Copy link
Owner

arvkevi commented Apr 28, 2023

There's a bug in the workflow file.

Pull request events are checking out the ref from main. See the checkout step of this job in #147 is checking out c525bbb.

The desired workflow is to checkout the most recent commit on the pr branch and run tests on it.

@Shotgunosine
Copy link
Contributor

So I think this is because the action is creating a temporary merge commit and checking that out:
actions/checkout#426. Commit 525bbb isn't in the main repo's git log, or in the PR's git log. It's a new commit simulating the results of merging the PR.

Line 48 here hints at this:
https://github.com/arvkevi/kneed/actions/runs/4829749517/jobs/8605149399#step:2:53
"/usr/local/bin/git -c protocol.version=2 fetch --no-tags --prune --progress --no-recurse-submodules --depth=1 origin +c525bbbe8cd6a78a66be1535c031c05d8ad9a321:refs/remotes/pull/147/merge"

@arvkevi arvkevi closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants