Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(publish-metrics): change vendor attributes format for consistency #2466

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

InesNi
Copy link
Contributor

@InesNi InesNi commented Feb 5, 2024

Description

Changing the attributes format of the Dynatrace and New Relic reporters tracing feature (introduced in #2418 ) from object:

attributes:
  testType: load
  tool: Artillery

to array of strings:

attributes:
  - "testType:load"
  - "tool:Artillery"

for consistency reasons, as the equivalent setting for the metrics and events in those reporters uses the string format.
e.g. New Relic reporter config for metrics and events:

config:
  plugins:
    publish-metrics:
      - type: newrelic
        licenseKey: "{{ $env.NR_LICENSE_KEY }}"
        region: eu
        prefix: "artillery.publish_metrics_plugin."
        attributes:
          - "testType:LoadTest"
          - "tool:Artillery"
        event:
          accountId: "{{ $env.NR_ACCOUNT_ID }}"
          eventType: "Artillery_load_test"
          attributes:
            - "alertType:info"
            - "priority:low"

@InesNi InesNi merged commit 981fcd0 into main Feb 5, 2024
15 checks passed
@InesNi InesNi deleted the improve-in-reporter-configuration-consistency branch February 5, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants