feat: add support for running on Fargate Spot #2464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating with FARGATE_SPOT allows on-demand Fargate tasks to be scheduled, but not vice versa
|
Does this work for existing clusters (like the default one)? I thought we would have to leverage If/When it does work for existing cluster, it might be worth just altering one of the tests to run on spot, to give us free testing of this feature? |
hassy
commented
Feb 2, 2024
| @@ -889,7 +890,7 @@ async function createArtilleryCluster(context) { | |||
| await ecs | |||
| .createCluster({ | |||
| clusterName: ARTILLERY_CLUSTER_NAME, | |||
| capacityProviders: ['FARGATE'] | |||
| capacityProviders: ['FARGATE_SPOT'] | |||
There was a problem hiding this comment.
Setting this as the default provider allows scheduling on-demand Fargate tasks but not vice versa
|
@bernardobridge existing clusters have to be recreated, will be in the docs |
Cluster in us-east-2 in the test AWS account created with default FARGATE_SPOT capacity provided.
hassy
deleted the
hassy-art-1611-add-support-for-running-on-fargate-spot-capacity-providers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.