Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cloud): send all end test information in single event #2333

Merged

Conversation

bernardobridge
Copy link
Contributor

Description

Improves performance of the Cloud testrun:end, which makes the CLI end the test faster.

Pre-merge checklist

This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.

  • Does this require an update to the docs? No
  • Does this require a changelog entry? Yes

@bernardobridge bernardobridge changed the title Bernardobridge/art 1482 cli test run end changes refactor(cloud): send all end test information in single event Nov 28, 2023
@hassy
Copy link
Member

hassy commented Nov 29, 2023

Is there a way we could do this without passing another argument to onShutdown handlers? Would be best to keep the number of arguments those to a minimum as we don't want to encourage using them over beforeExit handlers.

@bernardobridge
Copy link
Contributor Author

bernardobridge commented Nov 29, 2023

Is there a way we could do this without passing another argument to onShutdown handlers? Would be best to keep the number of arguments those to a minimum as we don't want to encourage using them over beforeExit handlers.

Good shout @hassy! Turns out we already had a mechanism to pass data from beforeExit to onShutdown in the cloud platform, so I can just leverage that: c218de8

@bernardobridge bernardobridge merged commit 4d794e3 into main Dec 1, 2023
10 checks passed
@bernardobridge bernardobridge deleted the bernardobridge/art-1482-cli-test-run-end-changes branch December 1, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants