Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test_rng randomized by default in std #35

Merged
merged 2 commits into from Jul 27, 2021
Merged

Conversation

Pratyush
Copy link
Member

@Pratyush Pratyush commented Jul 26, 2021

Description

Makes test_rng use a randomized seed by default when std is set. The benefit of this is that our "fuzzing" tests actually explore the search space now. Longer term we should also introduce a fuzzing harness to explicitly perform the search. To recover the old deterministic behaviour, the user can set env DETERMINISTIC_TEST_RNG=1 when running tests.

Also makes the output of test_rng opaque to the user, by having it return impl Rng instead.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

CHANGELOG.md Outdated Show resolved Hide resolved
@Pratyush Pratyush merged commit d0be44c into master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant