Add iterable::Reverse.
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code comes from arkworks-rs/gemini and is used mostly within tests in order to efficiently provide streams to both time- and space- efficient algorithms in order to check consistency of the output. Despite this code is relevant only in testing environments, cfg(test) does not have visibility across libraries. Therefore, I'm opting for exposing it as public API. One alternative (maybe in the future?) is to use a new feature flag "test" to expose testing utilities, but feels overkill for this single one.
Pratyush
approved these changes
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code comes from arkworks-rs/gemini and is used mostly within tests in order to efficiently provide streams to both time- and space- efficient algorithms and check consistency of the output.
Despite this code is relevant only in testing environments,
cfg(test)does not have visibility across libraries.Therefore, I'm opting for exposing it as public API.
One alternative (maybe in the future?) is to use a new feature flag "test" to expose testing utilities, but feels overkill for this single one.