Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unwrapping if inverse doesn't exist #610

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

paberr
Copy link
Contributor

@paberr paberr commented Feb 24, 2023

Description

The final_exponentiation step for the MNT4/6 curves involved unwrapping an inverse operation,
which can cause ZKP related operations (e.g., verification) to panic.
Instead, it now early returns with None, should the inverse not exist.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code – does not affect any documentation
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

Sorry, something went wrong.

@paberr paberr requested review from a team as code owners February 24, 2023 11:41
@paberr paberr requested review from Pratyush, mmagician and weikengchen and removed request for a team February 24, 2023 11:41
Copy link
Member

@Pratyush Pratyush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@Pratyush Pratyush added this pull request to the merge queue Feb 24, 2023
Merged via the queue into arkworks-rs:master with commit 744ed7e Feb 24, 2023
@paberr paberr deleted the pb/fix-mnt branch February 24, 2023 15:17
aleasims pushed a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
* Avoid unwrapping if inverse doesn't exist

* Update changelog.
aleasims added a commit to NilFoundation/arkworks-algebra that referenced this pull request Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants