Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to sort CollectionItem elements less often #3241

Merged
merged 4 commits into from Dec 21, 2023
Merged

Conversation

diegohaz
Copy link
Member

@diegohaz diegohaz commented Dec 21, 2023

Closes #3214

Copy link

changeset-bot bot commented Dec 21, 2023

🦋 Changeset detected

Latest commit: ad0177b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ariakit/core Patch
@ariakit/react-core Patch
@ariakit/react Patch
@ariakit/test Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Dec 21, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ad0177b:

Sandbox Source
Ariakit Configuration

@diegohaz diegohaz merged commit 1dbc4fc into main Dec 21, 2023
16 checks passed
@diegohaz diegohaz deleted the collection-store-sort branch December 21, 2023 10:18
diegohaz added a commit that referenced this pull request Dec 30, 2023
Fix a regression introduced by #3241 where the `renderedItems` state was
being reset on every scroll event.

Closes #3285
Re-opens #3214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple Menus rendered to page causes Maximum update depth exceeded.
1 participant