fix: get logs from artifact when workflow deleted instead of archived. Fixes: #14083 #14087
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shuangkun <tsk2013uestc@163.com>
shuangkun
force-pushed
the
archivedWorkflowLog
branch
from
23d40a1 to
539b42b
Compare
tczhao
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Could you explain how things work in your future PR.
People come in and out of the open source project, more context is helpful.
we have
// * `Archived` - has been archived and has live manifest
// * `Persisted` - has been archived and retrieved from db
archived comes from isArchivedWorkflow checks for Archived and Persisted
isWorkflowInCluster checks for Archived, allows workflow that are live to get logs from live pod instead of archived log
isubasinghe
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jan 30, 2025
…Fixes: argoproj#14083 (argoproj#14087) Signed-off-by: shuangkun <tsk2013uestc@163.com>
isubasinghe
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jan 30, 2025
…Fixes: argoproj#14083 (argoproj#14087) Signed-off-by: shuangkun <tsk2013uestc@163.com>
isubasinghe
pushed a commit
to pipekit/argo-workflows
that referenced
this pull request
Jan 31, 2025
…Fixes: argoproj#14083 (argoproj#14087) Signed-off-by: shuangkun <tsk2013uestc@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get logs from artifact when workflow deleted instead of archived
Fixes #14083
Motivation
Modifications
Verification
Before:
After fix：
