Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): clarify log deletion in log-viewer. Fixes #10993 #13788

Merged
merged 4 commits into from
Oct 19, 2024
Merged

fix(ui): clarify log deletion in log-viewer. Fixes #10993 #13788

merged 4 commits into from
Oct 19, 2024
+3 −2

Conversation

tooptoop4
Copy link
Contributor

Fixes #10993

@tooptoop4
Signed-off-by: tooptoop4 <33283496+tooptoop4@users.noreply.github.com>

Verified

This commit was signed with the committer’s verified signature.
bagder Daniel Stenberg
GPG key ID: 5CC908FDB71E12C2
Verified
Learn about vigilant mode
Loading
Loading status checks…
0d4435a
@tooptoop4 tooptoop4 changed the title feat(ui): clarify log deletion in log-viewer. Fixes (#10993) chore(ui): clarify log deletion in log-viewer. Fixes (#10993) Oct 18, 2024
@agilgur5 agilgur5 changed the title chore(ui): clarify log deletion in log-viewer. Fixes (#10993) chore(ui): clarify log deletion in log-viewer. Fixes #10993 Oct 19, 2024
@agilgur5 agilgur5 changed the title chore(ui): clarify log deletion in log-viewer. Fixes #10993 fix(ui): clarify log deletion in log-viewer. Fixes #10993 Oct 19, 2024
@agilgur5 agilgur5 added area/ui area/archive-logs Archive Logs feature labels Oct 19, 2024
tooptoop4 and others added 3 commits October 19, 2024 13:29
@tooptoop4 @agilgur5
Signed-off-by: tooptoop4 <33283496+tooptoop4@users.noreply.github.com>
Loading
Loading status checks…
f4061d3 
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Signed-off-by: tooptoop4 <33283496+tooptoop4@users.noreply.github.com>
@tooptoop4
Signed-off-by: tooptoop4 <33283496+tooptoop4@users.noreply.github.com>
Loading
Loading status checks…
0d32ac2
@tooptoop4
Signed-off-by: tooptoop4 <33283496+tooptoop4@users.noreply.github.com>
Loading
Loading status checks…
9c05f4b
agilgur5
agilgur5 approved these changes Oct 19, 2024
View reviewed changes
Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@agilgur5 agilgur5 merged commit ea6dae9 into argoproj:main Oct 19, 2024
16 checks passed
@isubasinghe isubasinghe mentioned this pull request Oct 30, 2024
Open
isubasinghe pushed a commit that referenced this pull request Oct 30, 2024
@tooptoop4 @isubasinghe
fix(ui): clarify log deletion in log-viewer. Fixes #10993 (#13788)
0581e94 
Signed-off-by: tooptoop4 <33283496+tooptoop4@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
isubasinghe pushed a commit that referenced this pull request Oct 30, 2024
@tooptoop4 @isubasinghe
fix(ui): clarify log deletion in log-viewer. Fixes #10993 (#13788)
5e4da81 
Signed-off-by: tooptoop4 <33283496+tooptoop4@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5

Assignees
No one assigned
Labels
area/archive-logs Archive Logs feature area/ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI: misleading message in pod logs viewer when using Archive Logs
2 participants
@tooptoop4 @agilgur5