fix(build): close pkg/apiclient/_.secondary.swagger.json
#12942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: guangwu <guoguangwug@gmail.com>
Joibel
approved these changes
Apr 16, 2024
|
LGTM, thanks for this. |
agilgur5
changed the title
pkg/apiclient/_.secondary.swagger.json
agilgur5
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
Makes sense to me and is general good practice to close file descriptors. Did you experience some error with codgen around this? Since it isn't used after and should be GC'd shortly after as well
Looks like ReadFile and WriteFile don't return file descriptors, so it would only be valid for Create
agilgur5
pushed a commit
that referenced
this pull request
Apr 19, 2024
Signed-off-by: guangwu <guoguangwug@gmail.com> (cherry picked from commit f0a867b)
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 6, 2024
…12942) Signed-off-by: guangwu <guoguangwug@gmail.com>
isubasinghe
pushed a commit
to isubasinghe/argo-workflows
that referenced
this pull request
May 7, 2024
…12942) Signed-off-by: guangwu <guoguangwug@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #TODO
Motivation
Modifications
Verification