Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass dnsconfig to agent pod. Fixes: #12824 #12825

Merged
merged 7 commits into from Mar 22, 2024
Merged

fix: pass dnsconfig to agent pod. Fixes: #12824 #12825

merged 7 commits into from Mar 22, 2024

Conversation

shuangkun
Copy link
Member

@shuangkun shuangkun commented Mar 20, 2024 •
edited

Fixes #12824

Motivation

Pass dnsconfig to agent pod.

Modifications

Verification

Local Tests.

@shuangkun
fix: pass through dnsconfig to agent pod. Fixes: argoproj#12824
ef65f15 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun
fix: test
3247363 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
tczhao
tczhao requested changes Mar 20, 2024
View reviewed changes
Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sense, since dnsconfig applies at the workflowspec level.

but mention this in the type WorkflowSpec struct {
Set DNS policy for the pod and argo agent

@tczhao tczhao self-assigned this Mar 20, 2024
@shuangkun
fix: test
ffdca94 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun
Copy link
Member Author

and argo agent

OK, Thanks.

@shuangkun
fix: codgen
1d6a2ea 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun
fix: test
74a16e8 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun shuangkun requested a review from tczhao March 20, 2024 20:55
@shuangkun
fix: to workflow pods.
73ed753 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun
fix: codegen
5035a7f 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun shuangkun closed this Mar 22, 2024
@shuangkun shuangkun reopened this Mar 22, 2024
@shuangkun shuangkun closed this Mar 22, 2024
@shuangkun shuangkun reopened this Mar 22, 2024
@shuangkun shuangkun closed this Mar 22, 2024
@shuangkun shuangkun reopened this Mar 22, 2024
@shuangkun shuangkun force-pushed the fix/dnsConfigInAgentPod branch 3 times, most recently from 7ffbd7d to 5035a7f Compare March 22, 2024 05:32
@shuangkun shuangkun requested a review from agilgur5 March 22, 2024 06:13
agilgur5
agilgur5 approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@agilgur5 agilgur5 merged commit dbff027 into argoproj:main Mar 22, 2024
68 of 75 checks passed
@shuangkun shuangkun mentioned this pull request Apr 4, 2024
Open
6 tasks
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Apr 19, 2024
agilgur5 pushed a commit that referenced this pull request Apr 19, 2024
@shuangkun @agilgur5
fix: pass dnsconfig to agent pod. Fixes: #12824 (#12825)
519faf0 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
(cherry picked from commit dbff027)
@agilgur5
Copy link
Member

Backported cleanly to release-3.5 as 519faf0

@agilgur5 agilgur5 added the area/agent Argo Agent that runs for HTTP and Plugin templates label Apr 26, 2024
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request May 6, 2024
@shuangkun @isubasinghe
fix: pass dnsconfig to agent pod. Fixes: argoproj#12824 (argoproj#12825)
75336f6 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request May 7, 2024
@shuangkun @isubasinghe
fix: pass dnsconfig to agent pod. Fixes: argoproj#12824 (argoproj#12825)
e0c16ff 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 approved these changes

@tczhao tczhao tczhao approved these changes

@terrytangyuan terrytangyuan Awaiting requested review from terrytangyuan terrytangyuan is a code owner

@sarabala1979 sarabala1979 Awaiting requested review from sarabala1979 sarabala1979 is a code owner

Assignees

@tczhao tczhao

Labels
area/agent Argo Agent that runs for HTTP and Plugin templates area/executor area/templates/http
Projects
None yet
Milestone
v3.5.x patches
Development

Successfully merging this pull request may close these issues.

Dnsconfig does not take effect in Agent pod
3 participants
@shuangkun @agilgur5 @tczhao