Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): show correct podGC message for deleteDelayDuration. Fixes: #12395 #12784

Merged
merged 5 commits into from Mar 12, 2024
Merged

fix(ui): show correct podGC message for deleteDelayDuration. Fixes: #12395 #12784

merged 5 commits into from Mar 12, 2024

Conversation

shuangkun
Copy link
Member

Fixes: #12395

Motivation

Show correct message on UI when podGC is enabled with deleteDelayDuration.

Modifications

Verification

Local test:
no deleteDelayDuration:
image
with deleteDelayDuration:
image

@shuangkun
fix: Incorrect message on UI when podGC is enabled with deleteDelayDu…
d799994 
…ration. Fixes: argoproj#12395

Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun shuangkun marked this pull request as draft March 12, 2024 09:13
@shuangkun shuangkun marked this pull request as ready for review March 12, 2024 09:17
@shuangkun shuangkun requested a review from agilgur5 March 12, 2024 09:17
@shuangkun shuangkun changed the title fix: Incorrect message on UI when podGC is enabled with deleteDelayDuration. Fixes: #12395 fix: incorrect message on UI when podGC is enabled with deleteDelayDuration. Fixes: #12395 Mar 12, 2024
@agilgur5 agilgur5 changed the title fix: incorrect message on UI when podGC is enabled with deleteDelayDuration. Fixes: #12395 fix(ui): show correct podGC message for deleteDelayDuration. Fixes: #12395 Mar 12, 2024
@agilgur5
Copy link
Member

fix: incorrect message on UI when podGC is enabled with deleteDelayDuration. Fixes: #12395

@shuangkun for reference, a commit/PR's subject/title should state what it does. Your title repeats the issue title, which is not what the fix does. Sometimes a fix is not even related to the issue title, for instance, the root cause could be very different from the issue title.

I changed the title to fix(ui): show correct podGC message for deleteDelayDuration. Fixes: #12395 as such

@shuangkun
Copy link
Member Author

fix: incorrect message on UI when podGC is enabled with deleteDelayDuration. Fixes: #12395

@shuangkun for reference, a commit/PR's subject/title should state what it does. Your title repeats the issue title, which is not what the fix does. Sometimes a fix is not even related to the issue title, for instance, the root cause could be very different from the issue title.

I changed the title to fix(ui): show correct podGC message for deleteDelayDuration. Fixes: #12395 as such

I'm ok. Thanks

@agilgur5 agilgur5 self-assigned this Mar 12, 2024
@shuangkun @agilgur5
Update ui/src/app/workflows/components/workflow-logs-viewer/workflow-…
890cff8 
…logs-viewer.tsx

Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Signed-off-by: shuangkun tian <72060326+shuangkun@users.noreply.github.com>
agilgur5
agilgur5 reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@agilgur5 agilgur5 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small modifications needed to the previous suggestion (I made some edits but the suggestion was applied too fast 😅)

ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx Outdated Show resolved Hide resolved
ui/src/app/workflows/components/workflow-logs-viewer/workflow-logs-viewer.tsx Outdated Show resolved Hide resolved
@agilgur5
Update ui/src/app/workflows/components/workflow-logs-viewer/workflow-…
899dec7 
…logs-viewer.tsx

Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
@agilgur5
Update ui/src/app/workflows/components/workflow-logs-viewer/workflow-…
1216227 
…logs-viewer.tsx

Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
agilgur5
agilgur5 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@agilgur5 agilgur5 enabled auto-merge (squash) March 12, 2024 15:32
@agilgur5
Update ui/src/app/workflows/components/workflow-logs-viewer/workflow-…
28229cd 
…logs-viewer.tsx

Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
@agilgur5 agilgur5 merged commit 20ece9c into argoproj:main Mar 12, 2024
15 checks passed
@shuangkun
Copy link
Member Author

Thanks!

agilgur5 added a commit to agilgur5/argo-workflows that referenced this pull request Mar 12, 2024
@shuangkun @agilgur5
fix(ui): show correct podGC message for deleteDelayDuration. Fixes: a…
03f9f75 
…rgoproj#12395 (argoproj#12784)

Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun tian <72060326+shuangkun@users.noreply.github.com>
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
@agilgur5
Copy link
Member

Cherry-picked into release-3.5 branch: 03f9f75

@agilgur5 agilgur5 added this to the v3.5.x patches milestone Apr 3, 2024
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request May 6, 2024
@shuangkun @agilgur5 @isubasinghe
fix(ui): show correct podGC message for deleteDelayDuration. Fixes: a…
61867de 
…rgoproj#12395 (argoproj#12784)

Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun tian <72060326+shuangkun@users.noreply.github.com>
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request May 7, 2024
@shuangkun @agilgur5 @isubasinghe
fix(ui): show correct podGC message for deleteDelayDuration. Fixes: a…
1a259cb 
…rgoproj#12395 (argoproj#12784)

Signed-off-by: shuangkun <tsk2013uestc@163.com>
Signed-off-by: shuangkun tian <72060326+shuangkun@users.noreply.github.com>
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
@agilgur5 agilgur5 mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agilgur5 agilgur5 agilgur5 approved these changes

Assignees

@agilgur5 agilgur5

Labels
area/ui
Projects
None yet
Milestone
v3.5.x patches
Development

Successfully merging this pull request may close these issues.

Incorrect message on UI when podGC is enabled with deleteDelayDuration
2 participants
@shuangkun @agilgur5