fix: mark task result completed use nodeId instead of podname. Fixes #12733 #12755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shuangkun <tsk2013uestc@163.com>
shuangkun
changed the title
4 tasks
agilgur5
added
area/controller
For context, see the root cause analysis in #12733 (comment) and above. A merge conflict in 3.5.5 was incorrectly resolved; this PR fixes that to the correct resolution (note that this PR is to the |
agilgur5
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Thanks for tracking this down and fixing it!
As this is a backport PR, going to merge this in cleanly as-is, but a regression test for this would be good to have per #12733 (comment)
agilgur5
changed the title
4 tasks
|
I wonder if we are planning to do a 3.5.6 release to include this fix? |
|
Yea it'll be released with 3.5.6 -- the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12733
mark task result completed use nodeId instead of podname
Motivation
Modifications
Verification