Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log): change task set to task result. #12749

Merged
merged 1 commit into from
Mar 6, 2024
Merged

fix(log): change task set to task result. #12749

merged 1 commit into from
Mar 6, 2024

Conversation

shuangkun
Copy link
Member

@shuangkun shuangkun commented Mar 6, 2024 •
edited

Log change. task set -> task result

Motivation

Modifications

Verification

@shuangkun
chore: change log info
96d15fa 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun shuangkun changed the title log: change log task set to task result. chore(log): change log task set to task result. Mar 6, 2024
@shuangkun shuangkun changed the title chore(log): change log task set to task result. chore(log): change task set to task result. Mar 6, 2024
Joibel
Joibel approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@Joibel Joibel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shuangkun
Copy link
Member Author

LGTM

Thanks！

@agilgur5 agilgur5 changed the title chore(log): change task set to task result. fix(log): change task set to task result. Mar 6, 2024
@agilgur5
Copy link
Member

agilgur5 commented Mar 6, 2024

I edited this to a fix since this a pretty common log for new users, so the correction makes the log message more understandable

agilgur5
agilgur5 approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction

@agilgur5 agilgur5 merged commit d805b7f into argoproj:main Mar 6, 2024
30 of 32 checks passed
agilgur5 pushed a commit that referenced this pull request Apr 19, 2024
@shuangkun @agilgur5
fix(log): change task set to task result. (#12749)
eec6ae0 
Co-authored-by: Anton Gilgur <agilgur5@gmail.com>
Signed-off-by: shuangkun <tsk2013uestc@163.com>
(cherry picked from commit d805b7f)
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Apr 19, 2024
@agilgur5
Copy link
Member

Backported to release-3.5 as eec6ae0

  • Fixed merge conflicts with the docs link since it's release-3.5 on release-3.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joibel Joibel Joibel approved these changes

@agilgur5 agilgur5 agilgur5 approved these changes

Assignees
No one assigned
Labels
area/executor
Projects
None yet
Milestone
v3.5.x patches
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shuangkun @agilgur5 @Joibel