fix: patch report outputs completed if task result not exists. #12748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shuangkun <tsk2013uestc@163.com>
shuangkun
changed the title
shuangkun
changed the title
Joibel
approved these changes
Mar 6, 2024
|
Thanks！ |
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
|
Fixed merge conflict. |
agilgur5
approved these changes
Mar 6, 2024
agilgur5
pushed a commit
that referenced
this pull request
Apr 19, 2024
Co-authored-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: shuangkun <tsk2013uestc@163.com> (cherry picked from commit 0a75598)
|
Backported to
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure FinalizeOutput executes, let taskresult Completed if taskresult not exists.
Motivation
When executor didn't have create workflowtaskresult permission.
The workflow won't completed even if all pods completed. Bucause the FinalizeOutput did patch taskresults and annotations.
Modifications
patch report outputs completed if task result not exists.
Verification