refactor(build): simplify mkdocs build scripts
#12463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we no longer need a separate file in `hack/` since the new build in `mkdocs` 1.5+ is a one-liner - this is also more efficient as we only execute `mkdocs build` once now follow-up to e921056 Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
area/docs
jmeridth
approved these changes
Jan 4, 2024
Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
|
Fixed conflict |
jmeridth
approved these changes
Jan 6, 2024
7 tasks
terrytangyuan
approved these changes
Feb 5, 2024
agilgur5
added a commit
that referenced
this pull request
Apr 9, 2024
Signed-off-by: Anton Gilgur <agilgur5@gmail.com> Signed-off-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
|
Backported cleanly to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
hack/since the new build inmkdocs1.5+ is a one-linermkdocs buildonce nowfollow-up to #12360
Modifications
hack/check-mkdocs.shand all references to it--stricttoMakefile's existingmkdocs buildcommandVerification
Ran
make docssuccessfully and checked that the docs looked as expected (i.e. no changes).