Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the Maximum Recursion Depth prompt link in the CLI. #12015

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

luyang93
Copy link
Contributor

No description provided.

Signed-off-by: luyang93 <39150988+luyang93@users.noreply.github.com>
Copy link

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea that's the correct link: https://argoproj.github.io/argo-workflows/scaling/#maximum-recursion-depth

.md is how we refer to it inside the docs themselves, which gets converted when rendered. mkdocs doesn't run on the CLI though, so this needs to be the rendered link.

Thanks for the fix!

@agilgur5 agilgur5 added area/cli The `argo` CLI area/docs Incorrect, missing, or mistakes in docs labels Oct 16, 2023
@terrytangyuan terrytangyuan enabled auto-merge (squash) October 16, 2023 19:04
@terrytangyuan terrytangyuan merged commit 05fa1cb into argoproj:master Oct 16, 2023
@luyang93 luyang93 deleted the fix-cli-link branch October 17, 2023 03:49
terrytangyuan pushed a commit that referenced this pull request Nov 3, 2023
Signed-off-by: luyang93 <39150988+luyang93@users.noreply.github.com>
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request May 6, 2024
…j#12015)

Signed-off-by: luyang93 <39150988+luyang93@users.noreply.github.com>
agilgur5 added a commit that referenced this pull request Jul 6, 2024
…#12015)"

This reverts commit 18685ad, which was erroneously backported to `release-3.4` when it was a fix for a 3.5 feature

Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli The `argo` CLI area/docs Incorrect, missing, or mistakes in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants