fix: Make defaultWorkflow hooks work more than once #11693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As workflowDefaults are passed by pointer we're modifying them directly here before modifying them such that StrategicMerge can work. Undo the modification we make directly so that the next time we patch it's still there Signed-off-by: Alan Clucas <alan@clucas.org>
terrytangyuan
approved these changes
Aug 29, 2023
5 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
Sep 5, 2023
6 tasks
6 tasks
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As workflowDefaults are passed by pointer we're modifying them directly here before modifying them such that StrategicMerge can work.
Undo the modification we make directly so that the next time we patch it's still there.
Fixes a bug introduced in the fix in #11214
Verification
Run with workflowDefaults having hooks more than once.