fix: cron workflow initial filter value. Fixes #11685 #11686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zel0rd <zelord.kwoun@gmail.com>
terrytangyuan
approved these changes
Aug 27, 2023
agilgur5
reviewed
Aug 27, 2023
| @@ -13,6 +13,7 @@ interface Props { | |||
| export class CheckboxFilter extends React.Component<Props> { | |||
| constructor(props: any) { | |||
| super(props); | |||
| this.props.items.forEach(item => this.props.selected.push(item.name)); | |||
There was a problem hiding this comment.
mmm this is a bit of an anti-pattern, especially for a reusable component like this one (it's used in more than one place). The anti-pattern is more visible in a functional component; it would be modifying an argument.
It would be better to just set the initial selected props from the parent component. That ends up going two parents up with the initial state here
5 tasks
terrytangyuan
pushed a commit
that referenced
this pull request
Sep 5, 2023
8 tasks
3 tasks
dpadhiar
pushed a commit
to dpadhiar/argo-workflows
that referenced
this pull request
May 9, 2024
…oj#11686) Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11685
Modifications
Encountering some issues while using the Cron workflow feature.
Modifications
When I enter the cron workflow, the lists are displayed, but all the filters are removed and set to default values. This can confuse users compared to having all the phases filters selected from the beginning. Therefore, the state of the cron workflow should start with all selections made.
The second issue is related to modifying the cron in the cron workflow. The style of the Concurrency Policy is broken. The position and height of the Select box and Select arrow need to be adjusted.