Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change node in paramScope to taskNode at executeDAG (#11422) #11682

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

toyamagu-2021
Copy link
Member

@toyamagu-2021 toyamagu-2021 commented Aug 26, 2023

Signed-off-by: toyamagu2021@gmail.com toyamagu2021@gmail.com

Motivation

Fixes #11422

Modifications

  • Change node in scope to taskNode

Verification

image

Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
@toyamagu-2021 toyamagu-2021 changed the title fix: Change scope node to taskNode at executeTmplLifeCycleHook fix: Change node in paramScope to taskNode at executeTmplLifeCycleHook Aug 26, 2023
@toyamagu-2021 toyamagu-2021 changed the title fix: Change node in paramScope to taskNode at executeTmplLifeCycleHook fix: Change node in paramScope to taskNode at executeDAG (#11422) Aug 26, 2023
@toyamagu-2021 toyamagu-2021 marked this pull request as ready for review August 26, 2023 09:11
@terrytangyuan terrytangyuan enabled auto-merge (squash) August 26, 2023 11:41
@terrytangyuan terrytangyuan merged commit ba523bf into argoproj:master Aug 26, 2023
27 checks passed
@toyamagu-2021 toyamagu-2021 deleted the fix-11422 branch August 26, 2023 12:04
terrytangyuan pushed a commit that referenced this pull request Sep 5, 2023
…1682)

Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
) (argoproj#11682)

Signed-off-by: toyamagu2021@gmail.com <toyamagu2021@gmail.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lifecycle hooks executed when conditions are not met(DAG)
3 participants