Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed parent level memoization broken. Fixes #11612 (#11623) #11660

Merged
merged 1 commit into from Aug 23, 2023

Conversation

shmruin
Copy link
Contributor

@shmruin shmruin commented Aug 23, 2023

Fixes #11612

Motivation

This is cherry-pick of #11623 from master to release-3.4.11 branch
(Refer to #11648)

Modifications

change woc.wf.Status.Nodes.Set(...) to woc.wf.Status.Nodes[...] to feat unsupported feature on release.

Verification

Same as #11623

apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
  generateName: memoized-entrypoint-
spec:
  entrypoint: entrypoint
  templates:
  - name: entrypoint
    memoize:
      key: "entrypoint-key-1"
      cache:
        configMap:
          name: cache-top-entrypoint
    outputs:
        parameters:
          - name: url
            valueFrom:
              expression: |
                'https://argo-workflows.company.com/workflows/namepace/' + '{{workflow.name}}' + '?tab=workflow'
    steps:
      - - name: whalesay
          template: whalesay

  - name: whalesay
    container:
      image: docker/whalesay:latest
      command: [sh, -c]
      args: ["cowsay hello_world `date` > /tmp/hello_world.txt"]
    outputs:
      parameters:
      - name: hello
        valueFrom:
          path: /tmp/hello_world.txt

@terrytangyuan terrytangyuan merged commit 3b9b9ad into argoproj:release-3.4.11 Aug 23, 2023
3 checks passed
@agilgur5 agilgur5 added type/backport Backport of an existing PR to an older release branch area/memoization labels Mar 9, 2024
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
…oproj#11623) (argoproj#11660)

Signed-off-by: shmruin <meme_hm@naver.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/memoization type/backport Backport of an existing PR to an older release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants