Overriding parameter to retry workflow does not work when using WorkflowTempalate

[toyamagu-2021]

Pre-requisites

• I have double-checked my configuration
• I can confirm the issues exists when I tested with :latest
• I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

Description

• Changes in workflow parameters on retrying are not reflected when submitted from WorkflowTemplate.
  • 
• spec.arguments.parameters is changed as expected but not for status.storedWorkflowTemplateSpec
• If we change status.storedWorkflowTemplateSpec manually, it works fine.

Version

latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

spec:
  templates:
    - name: argosay
      inputs:
        parameters:
          - name: code
            value: '{{workflow.parameters.code}}'
      outputs: {}
      metadata: {}
      container:
        name: main
        image: argoproj/argosay:v2
        command:
          - sh
          - '-c'
        args:
          - exit '{{inputs.parameters.code}}'
        resources: {}
  entrypoint: argosay
  arguments:
    parameters:
      - name: code

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

Logs from in your workflow's wait container

kubectl logs -n argo -c wait -l workflows.argoproj.io/workflow=${workflow},workflow.argoproj.io/phase!=Succeeded