Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecated Slack Link in Help page Contact #11627

Merged
merged 2 commits into from Aug 20, 2023

Conversation

Leeeuijooo
Copy link
Contributor

Fixes #11615

Motivation

I wanted to communicate when I wanted to ask questions or get help while using Argo workflow.

However, I accessed the contact field link on the help page, but was connected to the deleted argo workflow slack workspace. 馃槶

I think In order to smoothly maintain the Argo workflow ecosystem, a forum for active communication should be provided 馃挭

Modifications

I simply modified the Contact link in the help.tsx source code among UI components.
Link (https://argoproj.slack.com/ -> https://argoproj.github.io/community/join-slack/ (Changed))

image

image

Verification

Copy link
Member

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO needs fixing. Looks like only your last commit in this PR has the DCO

Copy link
Member

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM. Nice catch! Thanks for fixing this

Signed-off-by: leeeuijoo <euijoo3233@gmail.com>
Signed-off-by: leeeuijoo <euijoo3233@gmail.com>
@terrytangyuan terrytangyuan merged commit c9c6e5c into argoproj:master Aug 20, 2023
23 checks passed
@agilgur5 agilgur5 changed the title fix: deprecated Link(Help-Contact) Issue fix: deprecated Slack Link in Help page Contact Feb 17, 2024
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI: non-existent Slack Workspace link on help page Issue
3 participants