Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade argosay image for security and build support arm64 #10435 #11613

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix: upgrade argosay image for security and build support arm64 #10435 #11613

merged 1 commit into from
Aug 18, 2023

Conversation

sonbui00
Copy link
Member

Fixes #10435

Motivation

  • Fix security
  • Run examples on MacOS

Modifications

  • Upgrade base image
  • Add/update build command for multiple arch

Verification

https://hub.docker.com/repository/docker/sonbui00/argosay

Note

Run DOCKER_PUSH=true make argosayv1 to build and push v1
Then run DOCKER_PUSH=true make argosay to build and push v2

@sonbui00 sonbui00 marked this pull request as ready for review August 18, 2023 14:27
@terrytangyuan terrytangyuan merged commit 23d6da6 into argoproj:master Aug 18, 2023
23 checks passed
@terrytangyuan terrytangyuan mentioned this pull request Sep 5, 2023
Closed
5 tasks
terrytangyuan pushed a commit that referenced this pull request Sep 5, 2023
@sonbui00 @terrytangyuan
fix: upgrade base image for security and build support arm64 #10435 (#…
b0909c6 
…11613)

Signed-off-by: Son Bui <sonbv00@gmail.com>
@sonbui00
Copy link
Member Author

sonbui00 commented Feb 1, 2024

@terrytangyuan @isubasinghe @agilgur5 Can you help me build and push the docker image follow my note on the description?

@agilgur5
Copy link
Member

agilgur5 commented Feb 1, 2024 •
edited

See user report in #10435 (comment)

Apparently the argosay image is not pushed as part of CI?
Only Approver+ folks might have access to the Argoproj DockerHub account; it looks like Alex was the last to manually push this image.

Could we instead add a CI process to push this on main and release branches, like the other images?

@agilgur5 agilgur5 changed the title fix: upgrade base image for security and build support arm64 #10435 fix: upgrade argosay image for security and build support arm64 #10435 Feb 21, 2024
@agilgur5
Copy link
Member

agilgur5 commented Feb 21, 2024 •
edited

I'm wondering if we should just remove and replace argosay entirely. It seems like it was primarily used to add a small sleep for the PNS executor, which is no longer supported (argosay v1 was added in #2917 and v2 in #3001, for reference).

Shrinking the codebase by removing old hacks sounds like good tech debt to resolve

dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request May 9, 2024
@sonbui00 @dpadhiar
fix: upgrade base image for security and build support arm64 argoproj…
8870368 
…#10435 (argoproj#11613)

Signed-off-by: Son Bui <sonbv00@gmail.com>
Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
@agilgur5 agilgur5 mentioned this pull request May 13, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

argosay uses amd64 architecture instead of arm64 on arm64 machine
3 participants
@sonbui00 @agilgur5 @terrytangyuan