Default initialised NodeStatus causes random false failures.

[isubasinghe]

Pre-requisites

• I have double-checked my configuration
• I can confirm the issues exists when I tested with :latest
• I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

When a nodeID is missing from the NodeStatus hashmap, this should cause an error and that condition should be handled.
Unfortunately thanks to Go's design of maps, a default initialised value of a NodeStatus is returned instead of panicking (which is arguably the sane thing to do). Instead of assuming a value for the NodeStatus, either mark that node as an error or wait till the field has been populated.

Version

:latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

N/A

Logs from the workflow controller

N/A

Logs from in your workflow's wait container

N/A

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

[isubasinghe]

!

[caelan-io]

@isubasinghe - qq: does this fall under the larger effort in #10267 or is this separate?

[isubasinghe]

This is a separate issue, one of the container set related issues.
I need to open more issues for the other container set PRs