Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump github.com/redis/go-redis/v9 from 9.7.0 to 9.7.1 (#21957) #22255

Merged
merged 2 commits into from
Mar 9, 2025
Merged

chore(deps): bump github.com/redis/go-redis/v9 from 9.7.0 to 9.7.1 (#21957) #22255

merged 2 commits into from
Mar 9, 2025
+5 −5

Conversation

anandf
Copy link
Contributor

@anandf anandf commented Mar 8, 2025

Bumps github.com/redis/go-redis/v9 from 9.7.0 to 9.7.1.
Fixes #20824

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Sorry, something went wrong.

@dependabot @anandf
chore(deps): bump github.com/redis/go-redis/v9 from 9.7.0 to 9.7.1 (a…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
5930927 
…rgoproj#21957)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@anandf anandf requested a review from a team as a code owner March 8, 2025 01:52
svghadi
svghadi approved these changes Mar 8, 2025
View reviewed changes
Copy link
Contributor

@svghadi svghadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran a test using steps from #20824 (comment)
LGTM. Thanks

@anandf
Fixed missing cache github actions

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
Loading
Loading status checks…
706a31c 
Signed-off-by: anandf <anjoseph@redhat.com>
@anandf anandf requested a review from a team as a code owner March 8, 2025 07:18
@codecov Codecov
Copy link

codecov bot commented Mar 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.19%. Comparing base (66db4b6) to head (706a31c).
Report is 9 commits behind head on release-2.14.

Additional details and impacted files 
@@               Coverage Diff                @@
##           release-2.14   #22255      +/-   ##
================================================
- Coverage         55.24%   55.19%   -0.06%     
================================================
  Files               338      338              
  Lines             57240    57254      +14     
================================================
- Hits              31625    31603      -22     
- Misses            22920    22945      +25     
- Partials           2695     2706      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pasha-codefresh
Copy link
Member

Maybe better to merge it to master and after cherry-pick it? @svghadi @anandf

@svghadi
Copy link
Contributor

svghadi commented Mar 9, 2025 •
edited
Loading

Master is already updated 🚀 to 9.7.1 by dependabot with #21957

argo-cd/go.mod

Line 72 in cb135fd

github.com/redis/go-redis/v9 v9.7.1

@pasha-codefresh pasha-codefresh merged commit ed242b9 into argoproj:release-2.14 Mar 9, 2025
21 of 22 checks passed
@anandf
Copy link
Contributor Author

anandf commented Mar 9, 2025

@pasha-codefresh thanks for merging this PR. Can we create a z stream release v2.14.5 with this change ?

@anandf anandf deleted the fix_server_crash_goredis_2_14 branch March 10, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasha-codefresh pasha-codefresh

@svghadi svghadi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anandf @pasha-codefresh @svghadi