Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New protobuf versionning scheme such as 21.1 is not supported #33

Closed
3 tasks done
ajasmin opened this issue Jun 10, 2022 · 7 comments · Fixed by #78
Closed
3 tasks done

New protobuf versionning scheme such as 21.1 is not supported #33

ajasmin opened this issue Jun 10, 2022 · 7 comments · Fixed by #78
Assignees
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@ajasmin
Copy link

ajasmin commented Jun 10, 2022

Describe the problem

Protobuf has recently changed its versioning scheme. The release after 3.20 is named 21.0.

To reproduce

Sample workflow:

      - name: install protoc
        uses: arduino/setup-protoc@master
        with:
            version: 21.1

Expected behavior

protoc --version shows 3.21.1

'arduino/setup-protoc' version

v1

Additional context

No response

Issue checklist

  • I searched for previous reports in the issue tracker
  • I verified the problem still occurs when using the latest version
  • My report contains all necessary details
@per1234 per1234 added type: imperfection Perceived defect in any part of project topic: code Related to content of the project itself labels Jun 10, 2022
@per1234 per1234 self-assigned this Jun 10, 2022
@r-plus
Copy link

r-plus commented Aug 21, 2022

@imjasonh
Copy link

Am I reading correctly that there's effectively no way to get setup-protoc to install anything after v3.20.1, which is the latest default stable release, according to setup-protoc's criteria?

I've tried lots of different permutations on the version, and either get v3.20.1 if version is unset, or unable to get latest version if I specify anything else.

@jduan-highnote
Copy link

Can this issue get some love?

@vvakame
Copy link

vvakame commented Oct 17, 2022

@per1234 any update? 🌹

@woodruffw
Copy link

woodruffw commented Dec 16, 2022

I looked into this a little, and I think there are two reasonable approaches:

  1. Re-normalize versions like 21.11 into 3.21.11 for semver purposes, but otherwise keep them the same for release discover;
  2. The same, but re-normalize into 21.11.0 instead.

(2) is probably more correct, but I think either would work. I'll take a stab at this in a little bit.

@woodruffw
Copy link

Opened #58 with my attempted fix. I've only tested it with the new-style versions so far, but it works correctly for me.

@alessio-perugini
Copy link
Contributor

Released in https://github.com/arduino/setup-protoc/releases/tag/v2.0.0
Feel free to upgrade at @v2 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
8 participants