Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add image-scanner-with-trivy for ecosystem #5159

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Sep 9, 2023

Description

This PR is to add an AWS CDK Construct Library to Ecosystem.

Related issues

  • Close #XXX

Related PRs

  • #XXX
  • #YYY

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

Sorry, something went wrong.

@go-to-k go-to-k requested a review from knqyf263 as a code owner September 9, 2023 16:54
@CLAassistant
Copy link

CLAassistant commented Sep 9, 2023

CLA assistant check
All committers have signed the CLA.

@itaysk itaysk requested a review from AnaisUrlichs September 10, 2023 17:38
@AnaisUrlichs
Copy link
Contributor

Hi @go-to-k quick question, why does it use npm?
I'm new to AWS CDK

npm install image-scanner-with-trivy

@go-to-k
Copy link
Contributor Author

go-to-k commented Sep 11, 2023

Hi, @AnaisUrlichs.

AWS CDK has a feature called "Construct" that allows users to freely define resources, which can then be uploaded to a platform called "Construct Hub" as Construct libraries. The "image-scanner-with-trivy" I created this time is one such example.

"Construct Hub" is simply a collection and listing of Construct library packages that have been published to the npm registry.

In other words, these Construct libraries are actually npm packages, so if you want to use them with AWS CDK, you will need to install them via npm separately from the CDK CLI, so use npm.

You can also use yarn and so on.

@AnaisUrlichs AnaisUrlichs added this pull request to the merge queue Sep 11, 2023
@AnaisUrlichs
Copy link
Contributor

Ah, thank you for clarifying

Merged via the queue into aquasecurity:main with commit 7c68d4a Sep 11, 2023
@go-to-k go-to-k deleted the patch-1 branch September 11, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants