-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: validate SPDX with the JSON schema #5124
Conversation
@knqyf263 SPDX does not specify the patch version, so would it be correct to use the version |
@nikpivkin I think so. |
integration/integration_test.go
Outdated
@@ -34,6 +34,8 @@ import ( | |||
|
|||
var update = flag.Bool("update", false, "update golden files") | |||
|
|||
const SPDXSchema = "https://raw.githubusercontent.com/spdx/spdx-spec/development/v2.3.1/schemas/spdx-schema.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure we will forget to bump the version. Can we use spdx.Version
somehow as it is used here?
I see a problem between v2.3 and v2.3.1. If it is hard to identify the patch version, I think it is ok to use v2.3.
@nikpivkin Are you going to open another PR for |
Oh, I missed it. Thanks. |
Description
This PR adds validation of the SDPX-JSON report using the SPDX JSON schema.
Checklist