Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Optimize Dockerfile for reduced layers and size #5038

Merged
merged 2 commits into from
Aug 27, 2023
Merged

perf: Optimize Dockerfile for reduced layers and size #5038

merged 2 commits into from
Aug 27, 2023

Conversation

Leke-Ariyo
Copy link
Contributor

PR Title: Optimize Dockerfile for Efficiency and Size

What this PR does / why we need it:
Optimizes the Dockerfile to reduce the number of layers, improve efficiency, and decrease the overall image size.

Special notes for reviewer:
The main changes involve grouping related commands and cleaning up after installations to reduce image size.

Details:

Combined related commands to reduce Docker layers.
Grouped the installation of tools and libraries into a single RUN command.
Cleaned up the apt cache and removed unnecessary files post-installation.
Combined environment variable declarations for clarity.

How to test this PR:

Build the Docker image using the updated Dockerfile.
Run the container and ensure all functionalities are working as expected.

Screenshots:
N/A

Additional context:
This optimization aims to make the Dockerfile more efficient and the resulting image smaller in size.

@Leke-Ariyo Leke-Ariyo requested a review from knqyf263 as a code owner August 24, 2023 21:30
@CLAassistant
Copy link

CLAassistant commented Aug 24, 2023

CLA assistant check
All committers have signed the CLA.

@Leke-Ariyo Leke-Ariyo changed the title Optimize Dockerfile for reduced layers and size perf: Optimize Dockerfile for reduced layers and size Aug 24, 2023
@knqyf263
Copy link
Collaborator

Thanks for your contribution, but this Dockerfile is for development. We don't need to reduce the image size. Rather, ungrouped run commands make debugging easier from the cache perspective, etc.

@Leke-Ariyo
Copy link
Contributor Author

Thanks for your contribution, but this Dockerfile is for development. We don't need to reduce the image size. Rather, ungrouped run commands make debugging easier from the cache perspective, etc.

I just made an update, thanks for that comment

@knqyf263 knqyf263 enabled auto-merge August 27, 2023 07:17
@knqyf263 knqyf263 added this pull request to the merge queue Aug 27, 2023
Merged via the queue into aquasecurity:main with commit 5d8da70 Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants