Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug][move-compiler-v2] Double-check whether path canonicalization is needed for move-model::add_source and elsewhere #13192

Open
brmataptos opened this issue May 3, 2024 · 1 comment
Open

[Bug][move-compiler-v2] Double-check whether path canonicalization is needed for move-model::add_source and elsewhere #13192

brmataptos opened this issue May 3, 2024 · 1 comment
Labels
bug Something isn't working compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale

Comments

@brmataptos
Copy link
Contributor

馃悰 Bug

move-compiler-v2 and move-model use file names as keys for things. But they are also used as user-visible outputs. We need to double-check that we aren't double-compiling or missing properties due to files reachable on multiple paths somehow.
@brmataptos brmataptos added the bug Something isn't working label May 3, 2024
@brmataptos
Copy link
Contributor Author

brmataptos commented May 3, 2024 •
edited

For example, see move-model/src/lib.rs near line 188:

target_sources_names.contains(fname.as_str()),

@brmataptos brmataptos mentioned this issue May 3, 2024
Merged
21 tasks
@sausagee sausagee added the stale-exempt Prevents issues from being automatically marked and closed as stale label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working compiler-v2 stale-exempt Prevents issues from being automatically marked and closed as stale
Projects
Move Language and Runtime
Status: For Grabs
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sausagee @brmataptos