Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]Unknown manifest field "upgrade_policy" #13182

Open
brmataptos opened this issue May 2, 2024 · 2 comments
Open

[Bug]Unknown manifest field "upgrade_policy" #13182

brmataptos opened this issue May 2, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@brmataptos
Copy link
Contributor

馃悰 Bug

The field "upgrade_policy" appears in a number of Aptos Move examples and e2e-move tests, but the manifest_parser doesn't know about it. It shows up as a warning when processing the Move.toml file (try --nocapture when running aptos-move-examples tests). As this field is documented (see https://aptos.dev/move/book/package-upgrades/#how-it-works) it should be supported in third_party/move/tools/move-package/src/source_package/manifest_parser.rs.

Here are the tests including it:

./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_init_module_failed/Move.toml:upgrade_policy = "immutable"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_init_module_second_attempt/Move.toml:upgrade_policy = "immutable"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_initial/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_initial_arbitrary/Move.toml:upgrade_policy = "arbitrary"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_initial_immutable/Move.toml:upgrade_policy = "immutable"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_large/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_large_upgrade/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_other_name/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_upgrade_compat/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_upgrade_incompat/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/code_publishing.data/pack_upgrade_incompat_arbitrary/Move.toml:upgrade_policy = "arbitrary"
./aptos-move/e2e-move-tests/src/tests/error_map.data/pack/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/object_code_deployment.data/pack_initial/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/object_code_deployment.data/pack_initial_immutable/Move.toml:upgrade_policy = "immutable"
./aptos-move/e2e-move-tests/src/tests/object_code_deployment.data/pack_other_name/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/object_code_deployment.data/pack_upgrade_compat/Move.toml:upgrade_policy = "compatible"
./aptos-move/e2e-move-tests/src/tests/object_code_deployment.data/pack_upgrade_incompat/Move.toml:upgrade_policy = "compatible"
./aptos-move/move-examples/cli_args/Move.toml:upgrade_policy = "compatible"
./aptos-move/move-examples/dao/nft_dao/Move.toml:upgrade_policy = "immutable"
./aptos-move/move-examples/large_packages/Move.toml:upgrade_policy = "compatible"
./aptos-move/move-examples/large_packages/large_package_example/Move.toml:upgrade_policy = "compatible"
./aptos-move/move-examples/package_manager/Move.toml:upgrade_policy = "compatible"
./aptos-move/move-examples/resource_account/Move.toml:upgrade_policy = "compatible"
@brmataptos brmataptos added the bug Something isn't working label May 2, 2024
@wrwg
Copy link
Contributor

wrwg commented May 3, 2024

Because third-party needed to be agnostic until recently, this must have been kept out of it as it is aptos specific. Moving forward we replace the package system so I don't think this bug should be kept.

@brmataptos
Copy link
Contributor Author

Are you saying that you have expect that it will be fixed, so this bug should be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 馃啎 New
Development

No branches or pull requests

2 participants