Fix ActiveSupport Logger broadcast compatibility #969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unflxw
approved these changes
Jun 1, 2023
jeffkreeftmeijer
approved these changes
Jun 2, 2023
|
@luismiramirez To give Jörg co-author ship recognition by GitHub, please use his email address used in his commit, rather than his username. |
tombruijn
approved these changes
Jun 2, 2023
We were using `progname` instead of group in the AppSignal Logger `add`
method. Making the convenience methods such as `warn`, `info`, etc. Not
logging anything when called as in:
```ruby
Rails.logger.warn("Warning message")
```
This commits updates that to use `group` instead of `progname` as in the
original Ruby Logger implementation.
Co-authored-by: Jörg Schiller <joergschiller@googlemail.com>
luismiramirez
force-pushed
the
fix-logger-add
branch
from
8d6348e
to
1750072
Compare
|
v3.4.4 of the gem covers this fix: https://rubygems.org/gems/appsignal/versions/3.4.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
prognameinstead of group in the AppSignal Loggeraddmethod. Making the convenience methods such aswarn,info, etc. Not logging anything when called as in:This commits updates that to use
groupinstead ofprognameas in the original Ruby Logger implementation.Based on the contents of: #967