Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run minutely probes on console #963

Merged
merged 1 commit into from May 2, 2023

Conversation

unflxw
Copy link
Contributor

@unflxw unflxw commented May 2, 2023

When running the Rails console, the minutely probes should not be active.

Fixes #962.

@unflxw unflxw added the bug label May 2, 2023
@unflxw unflxw self-assigned this May 2, 2023
@backlog-helper
Copy link

backlog-helper bot commented May 2, 2023

✔️ All good!

New issue guide | Backlog management | Rules | Feedback

When running the Rails console, the minutely probes should not be
active.
@unflxw unflxw force-pushed the do-not-run-minutely-probes-on-console branch from 5ed76e5 to 4cd1601 Compare May 2, 2023 13:12
@unflxw unflxw merged commit d8ecc7b into main May 2, 2023
12 checks passed
@unflxw
Copy link
Contributor Author

unflxw commented May 2, 2023

Forgot to add changeset, pushed it directly to main 🙊 d63d176 -- Nevermind, I played myself. There was already a changeset. Undone.

@jjb
Copy link
Contributor

jjb commented Jul 13, 2023

Great! Does this essentially disable all aspects of appsignal for console, or just the minutely probe? If some parts are left on, is that by design?

I have this in my bin/rails stub:

if ARGV.include?('console') || ARGV.include?('c')
  ENV['APPSIGNAL_ACTIVE'] = 'false'
end

@unflxw
Copy link
Contributor Author

unflxw commented Jul 13, 2023

@jjb This disables the minutely probes only.

I suppose we could disable all of AppSignal on the console by default, but I'm thinking that it might be convenient for AppSignal to be active in the Rails console, in order to be able to use it to test AppSignal itself. I'll raise this with the team.

I take it that your preference would be for it to be disabled? If so, could you elaborate on why? Have you encountered any issues when AppSignal is active in the Rails console?

@jjb
Copy link
Contributor

jjb commented Jul 13, 2023

gotcha

If i remember correctly from several months ago, the problems were:

  • mystery hosts with unhelpful names showing up on the appsignal dashboard (but maybe this was not from console but instead from things like rails db:migrate... or maybe both)
  • maybe some sort of logging output when console was starting up? only in some environments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AppSignal Sidekiq probe prematurely creates Redis pool now that Sidekiq creates the pool lazily
4 participants