Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agent to version 6f29190 #961

Merged
merged 2 commits into from Apr 26, 2023
Merged

Update agent to version 6f29190 #961

merged 2 commits into from Apr 26, 2023

Conversation

tombruijn
Copy link
Member

@tombruijn tombruijn commented Apr 25, 2023

Rename APPSIGNAL_ENVIRONMENT to public env version

Rename the internal APPSIGNAL_ENVIRONMENT env var to the publicly known
APPSIGNAL_APP_ENV env var.

This makes all the agent config options consistent with each other.

[skip changeset] because it requires an agent update that will include
a changeset.

Update agent to version 6f29190

  • Log revision config in boot debug log.
  • Update internal agent CLI start command.
  • Rename internal _APPSIGNAL_ENVIRONMENT variable to
    _APPSIGNAL_APP_ENV to be consistent with the public version.

Rename the internal APPSIGNAL_ENVIRONMENT env var to the publicly known
APPSIGNAL_APP_ENV env var.

This makes all the agent config options consistent with each other.

[skip changeset] because it requires an agent update that will include
a changeset.
- Log revision config in boot debug log.
- Update internal agent CLI start command.
- Rename internal `_APPSIGNAL_ENVIRONMENT` variable to
  `_APPSIGNAL_APP_ENV` to be consistent with the public version.
@tombruijn tombruijn self-assigned this Apr 25, 2023
@tombruijn tombruijn changed the title Rename app env Update agent to version 6f29190 Apr 25, 2023
@tombruijn tombruijn merged commit d6d7ef5 into main Apr 26, 2023
12 checks passed
@jjb
Copy link
Contributor

jjb commented Jul 13, 2023

Update internal agent CLI start command

What does this refer to?

I currently use the appsignal agent in standalone mode as such:

...../ext/appsignal-agent --config appsignal-agent.conf

will this change?

thanks!

@unflxw
Copy link
Contributor

unflxw commented Jul 14, 2023

@jjb That should still work as expected. 😄

Internally, when the integration's native extension starts the agent, it will start it in "integration mode", which affects how the agent reads environment variables, and how it manages its lifecycle. We recently changed the way in which we tell the agent to start in this mode.

@tombruijn
Copy link
Member Author

@jjb @unflxw it does have some other changes. Commit for reference (Private link).

For your particular question:

If you want to start the agent as it worked previously you need to run ./appsignal-agent start --config appsignal-agent.conf. Note the addition of the start subcommand.

You can also now run ./appsignal-agent --help for more information about how the CLI works.

@tombruijn tombruijn deleted the rename-app-env branch July 31, 2023 09:30
@tombruijn tombruijn restored the rename-app-env branch July 31, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants