Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeatable crashes and misbehavior in GitHub Windows CI #72121

Open
dabrahams opened this issue Mar 6, 2024 · 4 comments
Open

Repeatable crashes and misbehavior in GitHub Windows CI #72121

dabrahams opened this issue Mar 6, 2024 · 4 comments
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels Windows Platform: Windows

Comments

@dabrahams
Copy link
Collaborator

dabrahams commented Mar 6, 2024

Description

This step reliably caused crashes and other weird behaviors in my GitHub CI, on Windows only. The exact behavior could always be repeated by re-triggering the workflow run without deleting existing caches, but the misbehavior for any particular cache configuration varies. Most often there's an unceremonious crash during building with no diagnostic, but I've also seen my final step, which just runs, e.g., hylo/.build/debug/hc --version, fail, with Powershell reporting that hc is not a program, cmd or cmdlet. This is after everything built and passed all tests… so the executable must be there, right?

Reproduction

fork https://github.com/hylo-lang/hylo at 7a152a454, enable actions, and push some trivial change to trigger CI. When the run succeeds, then make another change and push that.

Expected behavior

success

Environment

GitHub runner, windows-latest, Swift 5.9

Additional information

No response

@dabrahams dabrahams added bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels Windows Platform: Windows labels Mar 6, 2024
@dabrahams
Copy link
Collaborator Author

Update: this has nothing to do with caches. I'm still seeing the behavior after disabling the caches for Windows.

@dabrahams dabrahams changed the title Use of cacheing in GitHub Windows CI produces repeatable crashes and misbehavior repeatable crashes and misbehavior in GitHub Windows CI Mar 6, 2024
@dabrahams dabrahams changed the title repeatable crashes and misbehavior in GitHub Windows CI Repeatable crashes and misbehavior in GitHub Windows CI Mar 6, 2024
@finagolfin
Copy link
Contributor

If this is happening without github caching too, is it reproducible off github, ie on a local Windows machine? If not, maybe this is just something related to the constrained resources of the free github Windows CI or its documented performance issues, actions/runner-images#7320.

@dabrahams
Copy link
Collaborator Author

I don't know. My latest bet is that the problem is in SPM on Windows, which is even less supported than SPM on Mac and Linux. I'm in the process of transitioning to CMake and if that makes the problem go away, we'll have confirmation.

@finagolfin
Copy link
Contributor

finagolfin commented Mar 18, 2024

#72221 suggests this isn't just a github issue for Windows, at least with the performance aspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A deviation from expected or documented behavior. Also: expected but undesirable behavior. triage needed This issue needs more specific labels Windows Platform: Windows
Projects
None yet
Development

No branches or pull requests

2 participants