Fix error description forwarding #143
Merged
+116
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes apple/swift-openapi-generator#730.
We were not correctly keeping
CustomStringConvertible
andLocalizedError
conformances separate for wrapper errors likeClientError
andServerError
. This lead to some user-thrown errors (in handlers, transports, and middlewares) to print less information than the error was actually providing (using a different method).Modifications
Properly untangle the two printing codepaths, and only call
localizedDescription
from the wrapper error'serrorDescription
.Also made the
localizedDescription
strings a bit more user-friendly and less detailed, as in some apps these errors might get directly rendered by a UI component that callslocalizedDescription
.Result
Error logging should now match adopter expectations.
Test Plan
Added unit tests for
{Client,Server}Error
printing methods.