Delay stream creation until the next loop tick #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: A recent change allowed stream creation to run immediately if the caller was on the correct event loop. Normally that's fine, however, it opens up a code path where streams can become activated twice which leads to a crash. Modifications: - Delay stream creation until the next loop tick - Add a loop tick to tests which now require it Result: Avoid re-entrantly activating streams twice.
glbrntt
added
the
patch-version-bump-only
rnro
approved these changes
Aug 23, 2023
dnadoba
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
A recent change allowed stream creation to run immediately if the caller was on the correct event loop. Normally that's fine, however, it opens up a code path where streams can become activated twice which leads to a crash.
Modifications:
Result:
Avoid re-entrantly activating streams twice.