H2 stream AsyncIterator non-sendable on 5.7 #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Marking `NIOHTTP2InboundStreamChannels.AsyncIterator` as non-sendable fails to compile on 5.6 however implicitly non-sendable will do, this is a nice-to-have. Modifications: Move the non-sendable annotation to only apply >= 5.7 Result: `NIOHTTP2InboundStreamChannels.AsyncIterator` is implicitly non-sendable on 5.6
Lukasa
added
the
patch-version-bump-only
Lukasa
approved these changes
Jul 4, 2023
|
API breakage checker is wrong |
FranzBusch
approved these changes
Jul 4, 2023
rnro
deleted the
async_channels_NIOHTTP2InboundStreamChannels_sendability_5_6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Marking
NIOHTTP2InboundStreamChannels.AsyncIteratoras non-sendable fails to compile on 5.6 however implicitly non-sendable will do, this is a nice-to-have.Modifications:
Move the non-sendable annotation to only apply >= 5.7
Result:
NIOHTTP2InboundStreamChannels.AsyncIteratoris implicitly non-sendable on 5.6