Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix availability mismatches #339

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Fix availability mismatches #339

merged 1 commit into from
Mar 12, 2025

Conversation

gjcairo
Copy link
Contributor

@gjcairo gjcairo commented Mar 12, 2025

#338 pointed to some availability guard platform mismatches on ARC and its extensions. This PR aims to fix these and make sure all platforms build correctly.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@gjcairo gjcairo added the 🔨 semver/patch No public API change. label Mar 12, 2025
@simonjbeaumont
Copy link
Contributor

Thanks for the quick patch here @gjcairo. LGTM assuming it builds on the other platforms too.

@gjcairo
Copy link
Contributor Author

gjcairo commented Mar 12, 2025

Just validated it builds fine with this patch on watchOS, visionOS, macOS, iOS and tvOS - I'll mark it as ready for review.

@gjcairo gjcairo marked this pull request as ready for review March 12, 2025 22:00
Copy link
Contributor

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gjcairo!

@gjcairo gjcairo merged commit a6ce32a into apple:main Mar 12, 2025
30 of 33 checks passed
@gjcairo gjcairo deleted the fix-availability branch March 12, 2025 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants