[CI] Enable Windows CI #77
Merged
+129
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation We want to make sure our packages build on all supported platforms. # Modification This PR enabled the Windows CI. # Result Better test coverage in our package.
FranzBusch
force-pushed
the
fb-windows-ci
branch
2 times, most recently
from
04127de to
e08acae
Compare
FranzBusch
force-pushed
the
fb-windows-ci
branch
from
e08acae to
9806356
Compare
|
@Lukasa Please lock in the win and require the Windows CI pipelines on PR but just the unit tests! I gotta work on making the other ones not show up at all. |
Lukasa
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to make sure our packages build on all supported platforms.
Modification
This PR enabled the Windows CI.
Result
Better test coverage in our package.