Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove redundant pageobject feature #472

Merged

Conversation

laolubenson
Copy link
Collaborator

@laolubenson laolubenson commented Oct 17, 2021

Change list

Please provide briefly described change list which are you going to propose.

Types of changes

What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New feature (non-breaking change which adds value to the project)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Documentation

  • Have you proposed a file change/ PR with appium to update documentation?

This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

  • Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

Details

Removes support for redundant SeleniumExtras code (containing the necessary Page object feature components). Removes the dependency to an unmaintained repository, unlinks this repository to selenium v3, and enables full .netStandard/core support.

The pageobject feature may return with .netStandard support in the future but will have to be a separate repo. Removing this code will prevent users from raising issues which lie in code that doesn't belong to us thus closes #444 #436 #385 #205 #179 #163 #121

Sorry, something went wrong.

@laolubenson laolubenson changed the title chore: remove redundant page object chore: remove redundant pageobject feature Oct 17, 2021
@mykola-mokhnach
Copy link

Could you please provide a proper issue description? It is not very clear to me why this change is needed

@laolubenson
Copy link
Collaborator Author

@mykola-mokhnach done

@laolubenson laolubenson force-pushed the feat/remove-page-objects-v5 branch from 207792f to 6294052 Compare October 20, 2021 08:19
@laolubenson laolubenson merged commit 6294052 into appium:release/5.0.0 Oct 20, 2021
@laolubenson laolubenson deleted the feat/remove-page-objects-v5 branch October 20, 2021 08:38
@laolubenson
Copy link
Collaborator Author

A force push merged this in. Build succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants