chore: remove redundant pageobject feature #472
Merged
+9
−4,565
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change list
Please provide briefly described change list which are you going to propose.
Types of changes
What types of changes are you proposing/introducing to .NET client?
Put an
x
in the boxes that applyDocumentation
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example
Integration tests
Details
Removes support for redundant SeleniumExtras code (containing the necessary Page object feature components). Removes the dependency to an unmaintained repository, unlinks this repository to selenium v3, and enables full .netStandard/core support.
The pageobject feature may return with .netStandard support in the future but will have to be a separate repo. Removing this code will prevent users from raising issues which lie in code that doesn't belong to us thus closes #444 #436 #385 #205 #179 #163 #121