Bug Fix: allow false in allowedClasses #623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Prior to 2.4.0,
allowedClasses
can be false, this has been an undocumented feature.Since 2.4.0, this behavior is broken. This PR reverted to the previous behavior where
false
is allowed in theallowedClasses
attribute.See #621 for more detail
What are the specific steps to test this change?
The following code is broken in the main branch of this base repo, but should work in the branch in this pr.
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
Other information: